Skip to content

Implement ranges::shuffle - #1055

Closed
Michael Schellenberger Costa (miscco) wants to merge 2 commits into
microsoft:masterfrom
miscco:ranges_shuffle
Closed

Implement ranges::shuffle#1055
Michael Schellenberger Costa (miscco) wants to merge 2 commits into
microsoft:masterfrom
miscco:ranges_shuffle

Conversation

@miscco

Copy link
Copy Markdown
Contributor

This implements the range::shuffle algorithm.

For whatever reason it mt19937 has -at least locally- problems fulfilling the uniform_random_bit_generator<remove_reference<_Urng>> requirement, which is peculiar as it does in the ranges::sample test.

@statementreply statementreply left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments also apply to ranges::sample. (Apparently the test for ranges::sample didn’t catch this)

Comment thread stl/inc/algorithm Outdated
Comment thread stl/inc/algorithm Outdated
Comment thread stl/inc/algorithm Outdated
Comment thread stl/inc/algorithm Outdated
Comment thread stl/inc/algorithm Outdated
Co-authored-by: statementreply <statementreply@gmail.com>
@miscco

Copy link
Copy Markdown
Contributor Author

Derp, thanks a lot

@miscco Michael Schellenberger Costa (miscco) changed the title Implement range::shuffle Implement ranges::shuffle Jul 19, 2020
@miscco

Copy link
Copy Markdown
Contributor Author

Merged with #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants