Skip to content

Modernize the ranges::find family - #1058

Merged
Casey Carter (CaseyCarter) merged 5 commits into
microsoft:masterfrom
miscco:ranges_find
Jul 27, 2020
Merged

Modernize the ranges::find family#1058
Casey Carter (CaseyCarter) merged 5 commits into
microsoft:masterfrom
miscco:ranges_find

Conversation

@miscco

@miscco Michael Schellenberger Costa (miscco) commented Jul 19, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This updates the ranges::find* algorithms to the latest way of implementing the algorithms.
It also updates all tests except find_end as there was a strange issue I need to understand.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the enhancement Something can be improved label Jul 19, 2020
CaseyCarter
Casey Carter (CaseyCarter) suggested changes Jul 20, 2020
View reviewed changes
Comment thread stl/inc/algorithm Outdated
Comment thread stl/inc/algorithm Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_first_of/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_first_of/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_first_of/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_first_of/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_if/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find/test.cpp
Comment thread tests/std/tests/P0896R4_ranges_alg_find_if_not/test.cpp Outdated
@miscco
Apply review comments from Casey
59ad573
@miscco @CaseyCarter
Rewrap
811b94c 
Co-authored-by: Casey Carter <cartec69@gmail.com>
@CaseyCarter Casey Carter (CaseyCarter) mentioned this pull request Jul 21, 2020
Merged
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) requested changes Jul 22, 2020
View reviewed changes

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just nitpicks!

Comment thread tests/std/tests/P0896R4_ranges_alg_find/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_first_of/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_if/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_if_not/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find/test.cpp Outdated
Comment thread tests/std/tests/P0896R4_ranges_alg_find_if/test.cpp Outdated
@miscco @StephanTLavavej
Apply suggestions from STL
091c142 
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
@CaseyCarter
Casey Carter (CaseyCarter) merged commit 98f37c3 into microsoft:master Jul 27, 2020
@CaseyCarter

Casey Carter (CaseyCarter) commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

Thanks for locating things to cleanup in find.

@CaseyCarter Casey Carter (CaseyCarter) removed their assignment Jul 27, 2020
Casey Carter (CaseyCarter) added a commit to CaseyCarter/STL that referenced this pull request Jul 28, 2020
@miscco @CaseyCarter @StephanTLavavej
Modernize the ranges::find family (microsoft#1058)
6d9619e 
Co-authored-by: Casey Carter <cartec69@gmail.com>
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+1 more reviewer
@CaseyCarter Casey Carter (CaseyCarter) CaseyCarter approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Something can be improved ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miscco @CaseyCarter @StephanTLavavej