Modernize ranges::for_each - #1060
Merged
Casey Carter (CaseyCarter) merged 4 commits intoJul 27, 2020
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
July 20, 2020 13:23
Casey Carter (CaseyCarter)
suggested changes
Jul 20, 2020
Contributor
Author
|
Urgh I think adding |
Contributor
Yes: |
Casey Carter (CaseyCarter)
approved these changes
Jul 21, 2020
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 22, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
One comment nitpick, otherwise looks great!
| assert(ranges::equal(expected, input)); | ||
|
|
||
| int some_value = 1729; | ||
| result.fun(some_value); |
There was a problem hiding this comment.
I observe that this test verifies that result.fun is invocable, but not that it actually contains the state accumulated by being invoked on each element. (An incorrect implementation could return a copy of the original callable object.) No change requested.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 22, 2020
Casey Carter (CaseyCarter)
approved these changes
Jul 22, 2020
Contributor
|
Thanks for modernizing each of these algorithms. |
Casey Carter (CaseyCarter)
pushed a commit
to CaseyCarter/STL
that referenced
this pull request
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This modernizes
ranges::for_eachandranges::for_each_nto the current state of the art