Fix thinko in ranges::iter_swap - #1072
Merged
Casey Carter (CaseyCarter) merged 2 commits intoJul 30, 2020
Merged
Conversation
...by transposing arguments to `_Iter_exchange_move`. Fixes microsoft#1067
Contributor
|
Did you really swap the arguments |
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 22, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good but I can’t unsee pre-existing lines! 😹
Casey Carter (CaseyCarter)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
July 22, 2020 04:49
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 22, 2020
Curtis J Bezault (cbezault)
approved these changes
Jul 29, 2020
Contributor
Author
|
Thanks for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...by transposing arguments to
_Iter_exchange_move.Fixes #1067
Blocking #1062.