Implement ranges::ssize - #1076
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoAug 1, 2020
Merged
Conversation
...per the proposed resolution of LWG-3403, which I just wrote and submitted to the LWG issues list (cplusplus/LWG#328).
Closed
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 22, 2020
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 23, 2020
Casey Carter (CaseyCarter)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
July 24, 2020 00:51
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 24, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 27, 2020
Miya Natsuhara (mnatsuhara)
left a comment
Contributor
There was a problem hiding this comment.
Everything looks good, just had one question (which to be fair is about an important part of the overall changes 😛)
Miya Natsuhara (mnatsuhara)
approved these changes
Aug 1, 2020
Miya Natsuhara (mnatsuhara)
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the helpful explanation! :)
Member
|
Thanks for the thorough review, Miya Natsuhara (@mnatsuhara)! I'll add this to the MSVC-PR port so we'll have 10 PRs total. |
Member
|
Thanks! This is a sign that the size of the Ranges library is getting close to the max! |
Contributor
|
requests eye rolling as a reaction |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...per the proposed resolution of LWG-3403, which I just wrote and submitted to the LWG issues list (cplusplus/LWG#328).
Partially addresses #39.