Skip to content

Implement ranges::reverse_copy - #1095

Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
microsoft:masterfrom
CaseyCarter:reverse_copy
Aug 5, 2020
Merged

Implement ranges::reverse_copy#1095
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
microsoft:masterfrom
CaseyCarter:reverse_copy

Conversation

@CaseyCarter

@CaseyCarter Casey Carter (CaseyCarter) commented Jul 27, 2020

Copy link
Copy Markdown
Contributor

No description provided.

@CaseyCarter Casey Carter (CaseyCarter) added cxx20 C++20 feature ranges C++20/23 ranges labels Jul 27, 2020
@CaseyCarter
Casey Carter (CaseyCarter) requested a review from a team as a code owner July 27, 2020 20:18
@CaseyCarter Casey Carter (CaseyCarter) mentioned this pull request Jul 27, 2020
Closed
miscco
Michael Schellenberger Costa (miscco) reviewed Jul 27, 2020
View reviewed changes
Comment thread tests/std/tests/P0896R4_ranges_alg_reverse_copy/test.cpp Outdated
StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) approved these changes Jul 29, 2020
View reviewed changes
Comment thread stl/inc/algorithm Outdated
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Jul 30, 2020

Copy link
Copy Markdown
Member

I've pushed a merge to resolve a "take both changes" conflict in tests/std/test.lst. I pushed a separate commit to fix a sorting issue I had noticed recently (this makes it easier to diff test.lst against dir /s /b /ad).

mnatsuhara
Miya Natsuhara (mnatsuhara) approved these changes Aug 4, 2020
View reviewed changes
Comment thread stl/inc/algorithm
Comment thread stl/inc/algorithm
@CaseyCarter Casey Carter (CaseyCarter) removed their assignment Aug 5, 2020
@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 622b62a into microsoft:master Aug 5, 2020
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Aug 5, 2020

Copy link
Copy Markdown
Member

Thanks for implementing this algorithm and accelerating it with pawREP's #804!

@CaseyCarter
Casey Carter (CaseyCarter) deleted the reverse_copy branch August 5, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+2 more reviewers
@miscco Michael Schellenberger Costa (miscco) miscco left review comments
@mnatsuhara Miya Natsuhara (mnatsuhara) mnatsuhara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej)

Labels

cxx20 C++20 feature ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CaseyCarter @StephanTLavavej @miscco @mnatsuhara