Cache hardware thread count for <execution> - #1143
Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits intoAug 9, 2020
Merged
Conversation
resolves microsoft#1134 (conservatively) revert to what there were before atomic wait
Casey Carter (CaseyCarter)
suggested changes
Aug 4, 2020
Co-authored-by: Casey Carter <cartec69@gmail.com>
Alex Guteniev (AlexGuteniev)
requested a review
from Casey Carter (CaseyCarter)
August 4, 2020 16:25
Member
|
It looks like we can remove |
Billy O'Neal (BillyONeal)
approved these changes
Aug 4, 2020
Billy O'Neal (BillyONeal)
left a comment
Member
There was a problem hiding this comment.
LGTM with minor nitpicks about including more headers than we need and about lots of conversions
Co-authored-by: Billy O'Neal <bion@microsoft.com>
…lexGuteniev/STL into cache_execution_hw_concurrency
Billy O'Neal (BillyONeal)
approved these changes
Aug 5, 2020
Casey Carter (CaseyCarter)
approved these changes
Aug 5, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 6, 2020
Member
|
Thanks for restoring this performance optimization! 🚀 |
Alex Guteniev (AlexGuteniev)
deleted the
cache_execution_hw_concurrency
branch
August 10, 2020 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1134 (conservatively)
revert to what there were before atomic wait