Fix unnecessary self-move-assignments on calling deque erase(x,x) - #1148
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoAug 9, 2020
Merged
Conversation
Contributor
|
I believe the "conventional" solution would be to simply add if (_First == _Last) {
return _First;
}at the beginning of the function. |
Hamid Reza Arzaghi (Arzaghi)
marked this pull request as ready for review
August 4, 2020 20:22
Contributor
|
Also note, that formatting seems to be off. You need to use clang-format 10 with the file setting |
Contributor
Author
It adds an additional IF statement to the code as well. This IF statement will be effective in just a rare call. |
Casey Carter (CaseyCarter)
suggested changes
Aug 4, 2020
Billy O'Neal (BillyONeal)
approved these changes
Aug 4, 2020
Hamid Reza Arzaghi (Arzaghi)
requested a review
from Casey Carter (CaseyCarter)
August 4, 2020 23:38
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 5, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this!
I wonder whether we should have test coverage for this, but we can file a separate issue for that.
Hamid Reza Arzaghi (Arzaghi)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 5, 2020 15:35
Casey Carter (CaseyCarter)
approved these changes
Aug 5, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 5, 2020
Member
|
Thanks for fixing this bug, and congratulations on your first microsoft/STL commit! 🎉 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1118
I think it's the simplest method to solve the issue. however, it adds a little bit overhead to the library with an additional IF.
Any better idea?