add test to cover deque::erase(iter, iter) and avoiding self-move-assigns - #1203
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoAug 22, 2020
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 20, 2020
Hamid Reza Arzaghi (Arzaghi)
force-pushed
the
Fix_Issue1176
branch
from
August 20, 2020 19:22
5ffb8a2 to
f41f71e
Compare
Hamid Reza Arzaghi (Arzaghi)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 20, 2020 20:45
Casey Carter (CaseyCarter)
approved these changes
Aug 20, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 20, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks!
Member
|
Thanks for enhancing this test coverage! 😸 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followed by the Issue #1176 I've modified the test to cover the fixed issue #1118
The previous test case test
deque::erase(begin, begin)did not test self-assignment. Because in that special case the issue mentioned in #1118 wasn't happening. I've changed it toerase(begin+1, begin+1)which now actually can test for avoiding self-assignment.however, I wasn't sure that should I just modify the test case or add a new test block?