VS 2019 16.8 Preview 3 toolset update - #1290
Merged
Casey Carter (CaseyCarter) merged 2 commits intoSep 16, 2020
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
commented
Sep 15, 2020
Member
- Update the Azure Virtual Machine Scale Set.
- Update the README.
- Unskip the libcxx test that was affected by (MS-internal bug) VSO-1035737, which was fixed in Preview 3.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
September 15, 2020 03:44
Contributor
Contributor
|
Oh I didn't realise this already had other work in this one. I figured STL would have prefered to have toolset updates to not include anything extra. |
Casey Carter (CaseyCarter)
approved these changes
Sep 15, 2020
Curtis J Bezault (cbezault)
approved these changes
Sep 15, 2020
Member
Author
|
Thanks Igor Zhukov (@fsb4000) and Daniel Marshall (@SuperWig) - I had simply created this toolset update PR very hastily the night before my talk (upon realizing that CppCon attendees newly installing 16.8p3 and building the repo would see a libcxx failure here) and simply hadn't searched for the issues marked blocked on 16.8p3. Having the separate PR does make things simpler, thank you! |
This was referenced Sep 16, 2020
Contributor
|
Thanks for keeping our toolset current and unblocking the things waiting on 16.8p3! |
This was referenced Sep 16, 2020
Stephan T. Lavavej (StephanTLavavej)
deleted the
vs-2019-16.8-preview-3
branch
September 16, 2020 06:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.