<complex>: prevent invalid conversions - #1294
Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits intoSep 23, 2020
Merged
<complex>: prevent invalid conversions#1294Stephan T. Lavavej (StephanTLavavej) merged 5 commits into
Stephan T. Lavavej (StephanTLavavej) merged 5 commits into
Conversation
Hamid Reza Arzaghi (Arzaghi)
marked this pull request as ready for review
September 16, 2020 00:18
Hamid Reza Arzaghi (Arzaghi)
requested a review
from a team
as a code owner
September 16, 2020 00:18
Stephan T. Lavavej (StephanTLavavej)
requested changes
Sep 16, 2020
Hamid Reza Arzaghi (Arzaghi)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
September 16, 2020 14:15
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 17, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks! 😺
Casey Carter (CaseyCarter)
approved these changes
Sep 17, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Nice: an all-red PR. 🔥🔥🔥 Burn it all down! 🔥🔥🔥
Member
|
Thanks for fixing this bug, slightly improving compiler throughput, and improving our libcxx pass rate! 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1256