Skip to content

<locale>: std::ctype<char>::blank should return true only for space and tab #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Hamid Reza Arzaghi (Arzaghi) wants to merge 2 commits into from
Closed

<locale>: std::ctype<char>::blank should return true only for space and tab #1317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0b6c25
treat blank as a special case
Arzaghi Sep 24, 2020
4dff0b6
try to pass regex tests
Arzaghi Sep 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions stl/inc/regex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,11 +298,13 @@ public:
}

bool isctype(_Elem _Ch, char_class_type _Fx) const {
if (_Fx != static_cast<char_class_type>(-1)) {
return _Getctype()->is(_Fx, _Ch);
} else {
if (_Fx == static_cast<char_class_type>(_Ch_blank)) {
return _Getctype()->is(_SP, _Ch) || _Getctype()->is(_CN, _Ch);
} else if (_Fx == static_cast<char_class_type>(-1)) {
return _Ch == '_' // assumes L'_' == '_'
|| _Getctype()->is(_Ch_alnum, _Ch);
} else {
return _Getctype()->is(_Fx, _Ch);
}
}

Expand Down
3 changes: 3 additions & 0 deletions stl/inc/xlocale
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2611,6 +2611,9 @@ public:
using char_type = _Elem;

bool __CLR_OR_THIS_CALL is(mask _Maskval, _Elem _Ch) const { // test if element fits any mask classifications
if (_Maskval == blank) {
return _isblank_l(_Ch, _get_current_locale()) != 0;
}
return (_Ctype._Table[static_cast<unsigned char>(_Ch)] & _Maskval) != 0;
}

Expand Down