[feature/format] add parse_precision. - #1333
Merged
Charlie Barto (barcharcraz) merged 5 commits intoOct 16, 2020
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
requested changes
Oct 2, 2020
Charlie Barto (barcharcraz)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
October 13, 2020 20:32
Stephan T. Lavavej (StephanTLavavej)
requested changes
Oct 14, 2020
Charlie Barto (barcharcraz)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
October 15, 2020 19:44
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Oct 16, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good to me (with todo cards filed), feel free to squash this into feature/format when you're ready. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds parse_precision and tests. Tests are a tad lighter than other parse functions because it mostly relies on stuff already tested elsewhere.