Improve exception specification of iterator machinery - #1347
Merged
Stephan T. Lavavej (StephanTLavavej) merged 10 commits intoAug 16, 2022
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
October 6, 2020 19:56
Stephan T. Lavavej (StephanTLavavej)
requested changes
Oct 6, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Michael Schellenberger Costa (miscco)
force-pushed
the
noexcept_reverse_iterator
branch
from
April 23, 2021 18:55
cb2c226 to
490d45c
Compare
Member
nicole mazzuca (strega-nil-ms)
suggested changes
Aug 9, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
I would like to revive this PR; Michael Schellenberger Costa (@miscco), are you up for getting this pushed through, or should I take it on?
Contributor
Author
|
Hey, I will be on vacation the coming weeks, so feel free to plough ahead |
nicole mazzuca (strega-nil-ms)
force-pushed
the
noexcept_reverse_iterator
branch
from
August 12, 2022 16:36
983324c to
48f48c2
Compare
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 12, 2022
Casey Carter (CaseyCarter)
suggested changes
Aug 12, 2022
nicole mazzuca (strega-nil-ms)
requested a review
from Casey Carter (CaseyCarter)
August 12, 2022 21:30
Casey Carter (CaseyCarter)
approved these changes
Aug 12, 2022
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Final nits - I'll fix.
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 13, 2022
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks good! I have a few questions and suggestions.
nicole mazzuca (strega-nil-ms)
requested a review
from Stephan T. Lavavej (StephanTLavavej)
August 15, 2022 15:35
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 15, 2022
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks for strengthening the STL! 💪 🦾 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the exception specification of
move_iteratorandreverse_iteratoras well as thebegin()function and friends.Note that this (should be) merge clean with #2991 - there are no
_Unwrapped()changes, to allow #2991 to make those changes.