Move cgmanifest.json - #138
Conversation
| "component": { | ||
| "type": "git", | ||
| "git": { | ||
| "repositoryUrl": "https://github.com/microsoft/STL.git", |
There was a problem hiding this comment.
Oh no, the singularity! AHHHHhhhhhhhhh...... (No change requested.)
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
I capitalized your PR title, and edited the description to mention which GitHub issue this fixes. Looks good to me.
Be sure to edit these changes into the commit log, either when merging or now with a force-push*. *Ideally, |
|
I am still unclear as to what happens when we press "Squash and merge". Does this ever use the original commit? This is related to whether commits appear as "Verified" or not, and why not all of them in the history are. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Stephan T. Lavavej (@StephanTLavavej) Squash and merge combines all commits of the PR into one, and adds that commit to the target branch. The resulting squashed commit is shown as verified because it is signed with GitHub's GPG key. PRs which are merged using the rebase or merge commit strategy aren't signed by GitHub. Rebase merges can't be verified because they edit the commits to replay them on top of the target branch and therefore break the signature, but merge commit merges will show verified on the original commits if the author signed them with their GPG key because it does not edit the commits. |
|
Charles Milette (@sylveon) It can't be just that because #114 was squashed but still doesn't show 'Verified' |
#114 squashed unverified commits: https://github.com/microsoft/STL/pull/114/commits, so it wouldn't be signed. |
#134 squashed unverified comments and shows up as "verified". |
|
Then I'm not sure what's happening here. |
|
That makes several of us :) |
Please note that acceptance of community PRs will be delayed while we are
bringing our test and CI systems online. For more information, see the
README.md.
Description
Move CGmanifest to a more appropriate location. Fixes #125.
mirror of internal PR https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/204398?_a=overview
Checklist:
Working Draft.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 .
_Ugly.what happens to compile.
by an STL maintainer before CI is online, leave this unchecked for initial
submission).
members, adding virtual functions, changing whether a type is an aggregate or
trivially copyable, etc.). If unsure, leave this box unchecked and ask a
maintainer for help.