Implement allocating algorithms for ranges - #1383
Merged
Stephan T. Lavavej (StephanTLavavej) merged 25 commits intoJan 27, 2021
Merged
Implement allocating algorithms for ranges#1383Stephan T. Lavavej (StephanTLavavej) merged 25 commits into
Stephan T. Lavavej (StephanTLavavej) merged 25 commits into
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
October 20, 2020 08:27
Comment on lines
+6089
to
+6090
| _Uninitialized_backout<iter_value_t<_It>*> _Backout{ | ||
| _Temp_ptr, _RANGES _Uninitialized_move_unchecked(_First, _Mid, _Temp_ptr, _Temp_ptr + _Count1).out}; |
Contributor
Author
There was a problem hiding this comment.
I really do not like this function call as function argument.
I will most likely go over this soonish and give the result proper names
Contributor
Author
|
We are not using some of the return values from helper algorithms, such as I have for now removed the nodiscard here as it seems that this algorithm might also be a good candidate for not using nodiscard |
Michael Schellenberger Costa (miscco)
force-pushed
the
ranges_stable_partition
branch
from
October 20, 2020 10:17
7ec7acd to
d343edd
Compare
Closed
Contributor
Author
|
Added |
Contributor
Author
|
FYI I tried to unify this using |
Casey Carter (CaseyCarter)
suggested changes
Nov 4, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Partial review
Co-authored-by: Casey Carter <cartec69@gmail.com>
Casey Carter (CaseyCarter)
suggested changes
Nov 4, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Through inplace_merge.
Casey Carter (CaseyCarter)
suggested changes
Nov 5, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Ugh, still need to look at tests.
Co-authored-by: Casey Carter <cartec69@gmail.com>
Michael Schellenberger Costa (miscco)
force-pushed
the
ranges_stable_partition
branch
from
November 7, 2020 20:51
17057b8 to
68b6544
Compare
* `_Merge_move_to_buffer` shouldn't use `_Uninitialized_backout`; doing so could result in this function destroying a range of objects in the middle of the temporary buffer on exception from `iter_swap`. * `_Merge_move_to_buffer` shouldn't be using `iter_swap` anyway since we don't care about the pre-existing values in the destination range; it should indirectly_moving a la `*out = ranges::iter_move(in)`. * With the above changes, `_Merge_move_to_buffer` and `_Merge_move_from_buffer` can be refactored into a single function `_Merge_move_common`. * .`_Chunked_merge_to_buffer` and `_Chunked_merge_from_buffer` are then identical, and can be refactored into a single function `_Chunked_merge_common`.
Casey Carter (CaseyCarter)
self-requested a review
January 22, 2021 21:04
Casey Carter (CaseyCarter)
approved these changes
Jan 25, 2021
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
A bit of copypasta I'll apply fixes for, and one comment question.
Cleanup comment copypasta
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good to me, just found various nitpicks and a question about comment accuracy.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 26, 2021
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Approving with 3 unresolved questions about comment accuracy.
* Promote `_Isort_max` to namespace `std`; use it where appropriate in `<algorithm>` and `<execution>`. * Don't say "not less than" when we mean "greater than". * Refactor duplicate code into a `do`-`while` loop in `ranges::_Buffered_inplace_merge_common`. * Constant-propagate the value of `_Chunk` (`_Isort_max<_BidIt>`) through the body of `_Uninitialized_chunked_merge_unchecked`, remove the parameter, and bump the name to `_Uninitialized_chunked_merge_unchecked2` for ABI.
Say "Validate empty range" consistently instead of sometimes "ranges".
Casey Carter (CaseyCarter)
approved these changes
Jan 26, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 26, 2021
Member
|
For implementing these algorithms, I thank you. Most complicated in the classic STL, they were. 👽 ⚙️ |
Michael Schellenberger Costa (miscco)
deleted the
ranges_stable_partition
branch
January 27, 2021 10:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements remaining three stable algorithms. (Works towards #39.)
I am slightly worried about
inplace_mergeas I did some miniscule simplifications here and there and there are soo many .Also I really do not like all those free functions flying around. Would it make sense to keep them as static member functions of the respective CPO and only declare those that are used outside as
public?