hash<coroutine_handle<>>::operator() should be const - #1423
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoNov 7, 2020
Conversation
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Nov 4, 2020
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good. I searched and didn't find any other occurrences throughout the STL.
Contributor
Author
As did I, but it didn't occur to me to mention that fact (1) to show due diligence, and (2) to demonstrate how we probe the area around bugs to ensure we find all of the rot. |
Curtis J Bezault (cbezault)
approved these changes
Nov 4, 2020
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Stephan T. Lavavej (StephanTLavavej)
added a commit
to StephanTLavavej/STL
that referenced
this pull request
Nov 5, 2020
Member
|
Thanks for constantly improving the quality of the STL! 😹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1422.