Skip to content

Extracted _Choice<T>._Strategy to variable - #1426

Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
microsoft:masterfrom
futuarmo:extract_choice_strategy
Nov 7, 2020
Merged

Extracted _Choice<T>._Strategy to variable#1426
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
microsoft:masterfrom
futuarmo:extract_choice_strategy

Conversation

@futuarmo

@futuarmo futuarmo commented Nov 4, 2020

Copy link
Copy Markdown
Contributor

According to issue #1419 I've extracted Choice._Strategy to separate variable in <ranges> abd <xutility>

@futuarmo
futuarmo requested a review from a team as a code owner November 4, 2020 13:33
miscco
Michael Schellenberger Costa (miscco) reviewed Nov 4, 2020
View reviewed changes

@miscco Michael Schellenberger Costa (miscco) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. There are some minimal whitespace problems

Comment thread stl/inc/ranges Outdated
Comment thread stl/inc/ranges Outdated
miscco
Michael Schellenberger Costa (miscco) reviewed Nov 4, 2020
View reviewed changes
Comment thread stl/inc/xutility Outdated
CaseyCarter
Casey Carter (CaseyCarter) approved these changes Nov 4, 2020
View reviewed changes

@CaseyCarter Casey Carter (CaseyCarter) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see one occurrence of wonky formatting, which I'll fix by applying my suggestion, and then this LGTM.

Comment thread stl/inc/ranges Outdated
@CaseyCarter Casey Carter (CaseyCarter) added the enhancement Something can be improved label Nov 4, 2020
CaseyCarter
Casey Carter (CaseyCarter) reviewed Nov 4, 2020
View reviewed changes
Comment thread stl/inc/ranges Outdated
@CaseyCarter Casey Carter (CaseyCarter) linked an issue Nov 4, 2020 that may be closed by this pull request
<ranges>, <xutility>: Extract _Strategy to simplify code #1419
Closed
@CaseyCarter

Casey Carter (CaseyCarter) commented Nov 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

According to issue #1419 I've extracted Choice._Strategy to separate variable in <ranges> abd <xutility>

futuarmo I've linked up the issue manually, but FYI for next time if you include the GitHub magic words "Fixes #1419" in your commit message then GitHub will link the issue to the PR automatically.

@futuarmo

futuarmo commented Nov 4, 2020

Copy link
Copy Markdown
Contributor Author

Casey Carter (@CaseyCarter) ok, I've got it, thanks

StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) approved these changes Nov 4, 2020
View reviewed changes

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😸

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) changed the title Extracted Choice<T>._Strategy to variable Extracted _Choice<T>._Strategy to variable Nov 4, 2020
Stephan T. Lavavej (StephanTLavavej) added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej
microsoftGH-1426 Extracted _Choice<T>._Strategy to variable
3ab55b1
Stephan T. Lavavej (StephanTLavavej) added a commit to StephanTLavavej/STL that referenced this pull request Nov 5, 2020
@StephanTLavavej
microsoftGH-1426 Extracted _Choice<T>._Strategy to variable
43ac3f6
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Nov 7, 2020

Copy link
Copy Markdown
Member

Fixed a merge conflict in <ranges>; the recently added/moved views were too much for git to handle. Dropped attempted damage to _Drop_while_fn::operator() and manually applied this PR's change to _Reverse_fn::operator().

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 10d8e33 into microsoft:master Nov 7, 2020
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Nov 7, 2020

Copy link
Copy Markdown
Member

Thanks for improving the clarity of this ranges machinery! 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+2 more reviewers
@CaseyCarter Casey Carter (CaseyCarter) CaseyCarter approved these changes
@miscco Michael Schellenberger Costa (miscco) miscco approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej)

Labels

enhancement Something can be improved ranges C++20/23 ranges

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<ranges>, <xutility>: Extract _Strategy to simplify code

4 participants

@futuarmo @CaseyCarter @StephanTLavavej @miscco