Remove comments for resolved LWG issues - #1456
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoNov 14, 2020
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
November 12, 2020 07:13
Michael Schellenberger Costa (miscco)
force-pushed
the
LWG_issues
branch
from
November 12, 2020 07:31
3d6f3fc to
e186053
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Nov 12, 2020
52 tasks
Contributor
|
FWIW, I think I'd prefer to hold off reviewing this until we finish #1446 so we can continue to push any comment cleanups into this PR instead of having multiple such PRs. |
The following issues were recently resolved in the Standard, and are completely implemented: LWG-3403 Domain of ranges::ssize(E) doesn't match ranges::size(E) LWG-3420 cpp17-iterator should check that the type looks like an iterator first LWG-3428 single_view's in place constructor should be explicit LWG-3435 three_way_comparable_with<reverse_iterator<int*>, reverse_iterator<const int*>> LWG-3446 indirectly_readable_traits ambiguity for types with both value_type and element_type LWG-3465 compare_partial_order_fallback requires F < E LWG-3467 bool can't be an integer-like type
Member
|
I believe I've pushed changes for all of the implemented-and-commented issues. |
Contributor
Author
|
Awesome, thanks a lot ;) |
Curtis J Bezault (cbezault)
approved these changes
Nov 13, 2020
Casey Carter (CaseyCarter)
approved these changes
Nov 14, 2020
Member
|
Thanks for cleaning up these comments (and implementing many of these resolutions in the ranges code!). 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the comments for some of the resolved LWG issues.
#Addresses #1446