<compare>: Improve floating-point spaceship CPO codegen - #1475
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoDec 1, 2020
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
Stephan T. Lavavej (StephanTLavavej) merged 4 commits into
Conversation
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks, this is a great improvement - I will push fixes for a couple of comment typos but everything else looks like crystalline perfection to me. 💎
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Nov 21, 2020
Contributor
Author
|
Stephan T. Lavavej (@StephanTLavavej) I pushed fixes for comment typos after your approval. |
Curtis J Bezault (cbezault)
approved these changes
Nov 30, 2020
Curtis J Bezault (cbezault)
left a comment
Contributor
There was a problem hiding this comment.
This is a pretty cool change. I got to learn a couple of ones' complement tricks today.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Nov 30, 2020
Member
|
Thanks for increasing the spaceship's speed - onward to Alpha Centauri! 🚀 🛸 🪐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements floating-point
strong_orderandweak_orderwithout branching on the sign bit.Also adds signaling NaN test cases, enabled on clang only (MSVC "quiets" signaling NaNs when constant evaluated).