Build, but don't run, ARM/ARM64 tests - #1505
Merged
Stephan T. Lavavej (StephanTLavavej) merged 49 commits intoJan 27, 2021
Merged
Build, but don't run, ARM/ARM64 tests#1505Stephan T. Lavavej (StephanTLavavej) merged 49 commits into
Stephan T. Lavavej (StephanTLavavej) merged 49 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Curtis J Bezault (cbezault)
marked this pull request as ready for review
November 30, 2020 21:41
Curtis J Bezault (cbezault)
force-pushed
the
build-arm64
branch
from
December 1, 2020 18:37
55ad64f to
07e650c
Compare
This comment has been minimized.
This comment has been minimized.
Curtis J Bezault (cbezault)
force-pushed
the
build-arm64
branch
from
December 2, 2020 15:35
07e650c to
9ab1730
Compare
Curtis J Bezault (cbezault)
force-pushed
the
build-arm64
branch
3 times, most recently
from
December 11, 2020 19:58
b5e7535 to
1f8a449
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Do not test 16-bit and 32-bit padded types on ARM.
Fix compilation error due to missing intrinsics in LLVM
Curtis J Bezault (cbezault)
force-pushed
the
build-arm64
branch
4 times, most recently
from
December 15, 2020 18:55
bf87e5e to
12ebe78
Compare
Curtis J Bezault (cbezault)
force-pushed
the
build-arm64
branch
from
December 15, 2020 19:05
12ebe78 to
2dc447d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Curtis J Bezault (cbezault)
marked this pull request as draft
January 25, 2021 21:02
Curtis J Bezault (cbezault)
marked this pull request as ready for review
January 25, 2021 23:04
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 26, 2021
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
It is so awesome that this is powered by parallel: ${{ parameters.numShards }} instead of having to count from 1 to 8 (times 4 architectures).
😻 😻 😻 😻
😻 😻 😻 😻
This comment has been minimized.
This comment has been minimized.
Charlie Barto (barcharcraz)
approved these changes
Jan 26, 2021
Member
|
Every time a PR merges, it takes us one step closer to the vision: An STL on every processor and in every home. 💻 🏠 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for our test harness to have a build-only mode. We use this mode to cross-compile all the tests for ARM/ARM64.
It was discovered during the course of this PR that the ARM for Windows backend of
clanghas significant problems and as such we are disabling allclangtargeting ARM tests.A few build issues when targeting ARM64 with
clangwere also found:<bit>was using intrinsics not available onclangtargeting ARM64 so those were replaced with LLVM builtins.<atomic>was using the_InterlockedCompareExchange128family of functions which are not available onclang11 targeting ARM64 so I re-implemented them using builtins. (n.b. The_InterlockedCompareExchange_128_reland the_InterlockedCompareExchange_128I implemented are identical because the intrinsics onclseem to output the exact same assembly so I mirrored that.)I also found a couple of tests which were emitting warnings when compiled and so I silenced them.
Works towards #820.