Implement LWG 3268's PR to fix #150. - #151
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoOct 1, 2019
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
This is a back-compat fix for users who were saying things like `std::memory_order::memory_order_relaxed`. As there is nothing especially problematic about such usage, and LWG's ultimate resolution is unknown, I'm not deprecating these enumerators at this time. If and when this is voted into the WP in the deprecated clause, then we can add deprecated attributes. This mirrors a Microsoft-internal PR: https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/205250
Stephan T. Lavavej (StephanTLavavej)
requested review from
a team and
Andrew Fogarty (AFFogarty)
October 1, 2019 02:13
Casey Carter (CaseyCarter)
approved these changes
Oct 1, 2019
Billy O'Neal (BillyONeal)
approved these changes
Oct 1, 2019
Billy O'Neal (BillyONeal)
approved these changes
Oct 1, 2019
Member
|
Apparently you can approve harder! |
|
Hi, can I ask question there? Why old style memory_order_meow inside enum class is not a deprecated? For example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the Proposed Resolution for LWG-3268.
Fixes #150.
This is a back-compat fix for users who were saying things like
std::memory_order::memory_order_relaxed. As there is nothingespecially problematic about such usage, and LWG's ultimate resolution
is unknown, I'm not deprecating these enumerators at this time. If and
when this is voted into the WP in the deprecated clause, then we can
add deprecated attributes.
This mirrors a Microsoft-internal PR:
https://devdiv.visualstudio.com/DevDiv/_git/msvc/pullrequest/205250
Please note that acceptance of community PRs will be delayed while we are
bringing our test and CI systems online. For more information, see the
README.md.
Description
Checklist:
Working Draft. (LWG 3268's Proposed Resolution has NOT been voted into the Working Draft, but this change is necessary to avoid breaking real world code that conformed to C++11/14/17.)
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 .
_Ugly. (N/A, no tests here)what happens to compile. (N/A, no tests here)
by an STL maintainer before CI is online, leave this unchecked for initial
submission).
members, adding virtual functions, changing whether a type is an aggregate or
trivially copyable, etc.). If unsure, leave this box unchecked and ask a
maintainer for help.