Add an nvcc test which compiles all the headers at once - #1519
Merged
Stephan T. Lavavej (StephanTLavavej) merged 18 commits intoDec 17, 2020
Conversation
Curtis J Bezault (cbezault)
force-pushed
the
nvcc
branch
from
December 9, 2020 00:37
889e615 to
cb74dcb
Compare
Curtis J Bezault (cbezault)
force-pushed
the
nvcc
branch
from
December 9, 2020 00:44
1fe1b85 to
8bd3f13
Compare
Casey Carter (CaseyCarter)
suggested changes
Dec 10, 2020
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Some of these "requested changes" may actually be "requested explanation" ;)
Curtis J Bezault (cbezault)
requested a review
from Casey Carter (CaseyCarter)
December 11, 2020 06:01
Casey Carter (CaseyCarter)
approved these changes
Dec 12, 2020
Stephan T. Lavavej (StephanTLavavej)
requested changes
Dec 12, 2020
Curtis J Bezault (cbezault)
requested review from
Casey Carter (CaseyCarter) and
Stephan T. Lavavej (StephanTLavavej)
December 13, 2020 00:23
Casey Carter (CaseyCarter)
approved these changes
Dec 14, 2020
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 15, 2020
Member
|
Everything looks great. I've pushed a merge with |
Member
|
Thanks for figuring out the necessary magic to improve our CUDA coverage! 🔮 😻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #639
This PR also changes the mechanism by which we detect tests. We now recognize any file ending with
compile.pass.cpportest.cppundertr1/testsandstd/testsas a test. Thetest.lstfiles are now only for internal usage.