Add target architectures as features - #1539
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoDec 18, 2020
Merged
Conversation
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Dec 17, 2020
Casey Carter (CaseyCarter)
approved these changes
Dec 17, 2020
Member
🎯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
nvcctests are only meant to be run when testing thex64version of the STL so when they were added I made them require anx64feature. However, I forgot to add that feature when adding the tests and so the tests were just always skipped.This PR makes all the target architectures also features.