Fix uninitialized_meow memcpy optimization - #1548
Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits intoFeb 18, 2021
Merged
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
Stephan T. Lavavej (StephanTLavavej) merged 6 commits into
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
December 28, 2020 20:14
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_uninitialized_move
branch
from
December 28, 2020 22:08
c0d8bcc to
3f57e85
Compare
Member
|
It looks like the bug being fixed here is that the code was simply failing to compile - is that correct? |
Contributor
Author
|
Yes indeed |
Contributor
Author
|
Urgh, this is more broken than I thought. I need to add way more tests for ranges of different length. Also the |
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_uninitialized_move
branch
from
January 8, 2021 19:07
6876e51 to
e1f1a9b
Compare
Contributor
Author
|
Fixed more bugs and added more tests |
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_uninitialized_move
branch
from
January 23, 2021 12:28
e1f1a9b to
43fa0b5
Compare
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_uninitialized_move
branch
from
February 12, 2021 20:35
43fa0b5 to
342b431
Compare
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 12, 2021
Casey Carter (CaseyCarter)
suggested changes
Feb 12, 2021
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_uninitialized_move
branch
from
February 13, 2021 10:10
d9f5940 to
fe9e00e
Compare
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_uninitialized_move
branch
from
February 13, 2021 10:11
fe9e00e to
d5025c3
Compare
Casey Carter (CaseyCarter)
approved these changes
Feb 16, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 18, 2021
Casey Carter (CaseyCarter)
approved these changes
Feb 18, 2021
Member
|
(That's Cat for "Thanks for fixing this bug in |
Michael Schellenberger Costa (miscco)
deleted the
fix_uninitialized_move
branch
February 18, 2021 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by accident. Added some tests for the copy/move code pathes.