Add missed increment of _Current in the early return path - #1561
Merged
Stephan T. Lavavej (StephanTLavavej) merged 3 commits intoJan 15, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
January 7, 2021 21:04
Michael Schellenberger Costa (miscco)
force-pushed
the
fix_ranges_unique
branch
from
January 7, 2021 21:06
539e12d to
13a8617
Compare
Curtis J Bezault (cbezault)
approved these changes
Jan 7, 2021
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this correctness bug! I'll push a small comment change.
|
|
||
| auto result = unique(wrapped_input.begin(), wrapped_input.end(), countedEq, get_second); | ||
| STATIC_ASSERT(same_as<decltype(result), subrange<iterator_t<ReadWrite>>>); | ||
| assert(result.empty()); |
There was a problem hiding this comment.
Observation, no change requested: This could be more strict, by verifying that the empty subrange is at the end. However, it's unlikely that we'll damage this (and this PR certainly isn't), so it's just something to keep in mind for future tests.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jan 8, 2021
Contributor
Author
|
Thanks a lot Stephan T. Lavavej (@StephanTLavavej) |
Member
|
Thanks for this uniquely awesome bugfix! 😹 🪲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1560
When avoiding an superfluous comparison we missed to add the necessary increment to exclude the first element of the last group.