charconv internal functions for wchar_t buffers - #1587
Merged
Charlie Barto (barcharcraz) merged 8 commits intoFeb 4, 2021
Merged
charconv internal functions for wchar_t buffers#1587Charlie Barto (barcharcraz) merged 8 commits into
Charlie Barto (barcharcraz) merged 8 commits into
Conversation
Matt Stephanson (MattStephanson)
requested a review
from a team
as a code owner
January 25, 2021 07:39
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
- actually call wide Ryu functions - Widen __[df]2s_buffered_n - Don't wrap memcpy calls. - Use ternary operator and cast for static widen.
Matt Stephanson (MattStephanson)
requested a review
from Charlie Barto (barcharcraz)
January 30, 2021 04:43
Charlie Barto (barcharcraz)
approved these changes
Feb 1, 2021
Member
|
I believe that this should be retargeted to |
Stephan T. Lavavej (StephanTLavavej)
changed the base branch from
main
to
feature/format
February 4, 2021 04:39
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1569.