Add tests for basic_format_parse_context - #1597
Merged
Charlie Barto (barcharcraz) merged 10 commits intoFeb 6, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
January 29, 2021 20:55
Michael Schellenberger Costa (miscco)
force-pushed
the
format_tests
branch
from
January 29, 2021 21:11
c9ca892 to
cbea0a5
Compare
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jan 30, 2021
Contributor
Author
|
NOTE: I think I found a bug in clang-11. However it looks like it is already fixed in HEAD, does someone has a clang-12 lying around? |
Contributor
Author
|
Stephan T. Lavavej (@StephanTLavavej) I did some more changes, it might be good to have another look |
Michael Schellenberger Costa (miscco)
force-pushed
the
format_tests
branch
from
January 31, 2021 11:09
9e3e826 to
093a3a9
Compare
Co-authored-by: S. B. Tam <cpplearner@outlook.com>
Michael Schellenberger Costa (miscco)
force-pushed
the
format_tests
branch
from
January 31, 2021 11:45
093a3a9 to
e938cfa
Compare
Charlie Barto (barcharcraz)
suggested changes
Feb 4, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Feb 5, 2021
Charlie Barto (barcharcraz)
approved these changes
Feb 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for basic_format_parse_context and fixes some preexisting issues