VS 2019 16.9 Preview 4 toolset update - #1636
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoFeb 12, 2021
Merged
Conversation
README.md: Mention Preview 4. azure-pipelines.yml: Use the new pool. To potentially decrease resource consumption (at the cost of latency), require x86 to succeed before building and testing x64, ARM, and ARM64. tools/CMakeLists.txt: I've previously forgotten to update the minimum CMake version here.
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
February 10, 2021 02:34
Member
Author
|
The stage dependencies on Azure Pipelines match what I expected. This run took 19m 44s, longer than a previous successful run that took 7m 59s, also as expected. (I am not sure how much to "adjust" for the pipeline being totally new, as we've seen the very first run take longer than later runs.) |
Charlie Barto (barcharcraz)
approved these changes
Feb 10, 2021
Contributor
|
15min seems fine if we're not depending on the CI for our "in development" testing (that is: we expect developers to run the tests locally). |
Curtis J Bezault (cbezault)
approved these changes
Feb 10, 2021
Curtis J Bezault (cbezault)
left a comment
Contributor
There was a problem hiding this comment.
This makes me a little sad but will probably result in significant savings in the long run.
Casey Carter (CaseyCarter)
approved these changes
Feb 10, 2021
This was referenced Feb 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No product/test changes should be required; x86/x64 passed locally, and I saw no workarounds that can be removed.