Skip to content

feature/spaceship: Clause 17: Feature-test macro, yvals_core.h comment #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into from
Feb 22, 2021
Merged

feature/spaceship: Clause 17: Feature-test macro, yvals_core.h comment #1672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da893e4
Update feature-test macro, add yvals_core.h comment.
StephanTLavavej Feb 22, 2021
a71101a
Unskip support.limits.general/compare.version.pass.cpp.
StephanTLavavej Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stl/inc/yvals_core.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
// P1456R1 Move-Only Views
// P1474R1 Helpful Pointers For contiguous_iterator
// P1612R1 Relocating endian To <bit>
// P1614R2 Adding Spaceship <=> To The Library
// P1645R1 constexpr For <numeric> Algorithms
// P1651R0 bind_front() Should Not Unwrap reference_wrapper
// P1690R1 Refining Heterogeneous Lookup For Unordered Containers
Expand Down Expand Up @@ -1248,7 +1249,7 @@
#define __cpp_lib_starts_ends_with 201711L

#ifdef __cpp_lib_concepts // TRANSITION, GH-395
#define __cpp_lib_three_way_comparison 201711L
#define __cpp_lib_three_way_comparison 201907L
#endif // __cpp_lib_concepts

#define __cpp_lib_to_address 201711L
Expand Down
3 changes: 0 additions & 3 deletions tests/libcxx/expected_results.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,6 @@ std/language.support/support.limits/support.limits.general/functional.version.pa
std/language.support/support.limits/support.limits.general/iterator.version.pass.cpp FAIL
std/language.support/support.limits/support.limits.general/memory.version.pass.cpp FAIL

# C++20 P1614R2 "Adding Spaceship <=> To The Library"
std/language.support/support.limits/support.limits.general/compare.version.pass.cpp FAIL

# C++23 P1048R1 "is_scoped_enum"
std/utilities/meta/meta.unary/meta.unary.prop/is_scoped_enum.pass.cpp FAIL

Expand Down
3 changes: 0 additions & 3 deletions tests/libcxx/skipped_tests.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,9 +320,6 @@ language.support\support.limits\support.limits.general\functional.version.pass.c
language.support\support.limits\support.limits.general\iterator.version.pass.cpp
language.support\support.limits\support.limits.general\memory.version.pass.cpp

# C++20 P1614R2 "Adding Spaceship <=> To The Library"
language.support\support.limits\support.limits.general\compare.version.pass.cpp

# C++23 P1048R1 "is_scoped_enum"
utilities\meta\meta.unary\meta.unary.prop\is_scoped_enum.pass.cpp

Expand Down
6 changes: 3 additions & 3 deletions tests/std/tests/VSO_0157762_feature_test_macros/test.compile.pass.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,10 +1406,10 @@ STATIC_ASSERT(__cpp_lib_string_view == 201803L);
#if _HAS_CXX20 && defined(__cpp_lib_concepts) // TRANSITION, GH-395
#ifndef __cpp_lib_three_way_comparison
#error __cpp_lib_three_way_comparison is not defined
#elif __cpp_lib_three_way_comparison != 201711L
#error __cpp_lib_three_way_comparison is not 201711L
#elif __cpp_lib_three_way_comparison != 201907L
#error __cpp_lib_three_way_comparison is not 201907L
#else
STATIC_ASSERT(__cpp_lib_three_way_comparison == 201711L);
STATIC_ASSERT(__cpp_lib_three_way_comparison == 201907L);
#endif
#else
#ifdef __cpp_lib_three_way_comparison
Expand Down