Skip to content

<format>: initial replacement field tests (and numeric arg indexing) #1675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Charlie Barto (barcharcraz) merged 2 commits into from
Feb 24, 2021
Merged

<format>: initial replacement field tests (and numeric arg indexing) #1675

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fca0679
initial replacement field tests (and numeric arg indexing)
Feb 22, 2021
bb3b6cc
don't need to use the string_view_literals namespace.
Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion tests/std/tests/P0645R10_text_formatting_formatting/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#include <string_view>

using namespace std;

// TODO: fill in tests
template back_insert_iterator<string> std::vformat_to(
back_insert_iterator<string>, const locale&, string_view, format_args_t<back_insert_iterator<string>, char>);
Expand Down Expand Up @@ -75,5 +74,26 @@ int main() {
vformat_to(back_insert_iterator(output_string), locale::classic(), "}}x", make_format_args());
assert(output_string == "}x");

output_string.clear();
vformat_to(back_insert_iterator(output_string), locale::classic(), "{}", make_format_args((const char*) "f"));

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) Feb 23, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We conventionally avoid C-style casts everywhere (because they can do so many things, and are impossible to search for). Occurs below.

@miscco Michael Schellenberger Costa (miscco) Feb 23, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also say, that we should fix the bug and not try to work around it

@barcharcraz Charlie Barto (barcharcraz) Feb 24, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to merge and fix the bug in a PR, just because that unblocks Elnar and I have to get a foot X-Ray before fixing the overload set

assert(output_string == "f");

output_string.clear();
vformat_to(back_insert_iterator(output_string), locale::classic(), "{0} {0}", make_format_args((const char*) "f"));
assert(output_string == "f f");

// TODO: enable these in _Write function PR for sv and bool
/*
output_string.clear();
vformat_to(back_insert_iterator(output_string), locale::classic(), "{}", make_format_args("f"sv));
assert(output_string == "f");
*/

/*
output_string.clear();
vformat_to(back_insert_iterator(output_string), locale::classic(), "{}", make_format_args(true));
assert(output_string == "true");
*/

return 0;
}