Cleanup vector a bit - #1771
Merged
Stephan T. Lavavej (StephanTLavavej) merged 15 commits intoJun 29, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
March 23, 2021 10:08
Michael Schellenberger Costa (miscco)
force-pushed
the
cleanup_vector
branch
from
March 23, 2021 13:30
7bb4110 to
7cb8c2e
Compare
Stephan T. Lavavej (StephanTLavavej)
requested changes
Mar 23, 2021
This comment has been minimized.
This comment has been minimized.
Charlie Barto (barcharcraz)
suggested changes
Apr 30, 2021
Charlie Barto (barcharcraz)
approved these changes
Jun 12, 2021
Charlie Barto (barcharcraz)
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Still not thrilled with _Construct_n, but I'm OK if we merge that structure.
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks! All I noticed were minor issues so I'll validate and push changes.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 16, 2021
Member
|
Thanks for cleaning up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some cleanups that I found when looking at vector
We have special helper functions
_Uninitialized_meowthat are only used inside vector. However there was an additional indirection whose only purpose was to add_Getal()Cleaned up and generalized the construction of a vector with known size