[ranges] Apply resolution of LWG3502 to elements_view - #1878
Merged
Stephan T. Lavavej (StephanTLavavej) merged 4 commits intoMay 1, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
April 23, 2021 10:19
| _NODISCARD constexpr decltype(auto) operator*() const | ||
| noexcept(noexcept(_STD get<_Index>(*_Current))) /* strengthened */ { | ||
| return _STD get<_Index>(*_Current); | ||
| if constexpr (is_reference_v<range_reference_t<_Base>>) { |
Contributor
Author
There was a problem hiding this comment.
Note that I decided against implementing the exposition only get-element method
Michael Schellenberger Costa (miscco)
force-pushed
the
lwg3502
branch
from
April 23, 2021 10:43
a7965e5 to
d4c3384
Compare
Michael Schellenberger Costa (miscco)
force-pushed
the
lwg3502
branch
from
April 23, 2021 12:52
05252ff to
3e94a79
Compare
Casey Carter (CaseyCarter)
suggested changes
Apr 29, 2021
Contributor
|
FYI: I've pushed a commit that fixes non-functional nitpicks in the test code, a bug in the conditional |
Casey Carter (CaseyCarter)
approved these changes
Apr 29, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Apr 29, 2021
Member
|
Thanks for implementing this LWG issue resolution! All shall love conformance and despair! 😻 ✔️ 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1685