<chrono>: Adjust for leap seconds when formatting file_time - #1879
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoJun 29, 2021
Conversation
Miya Natsuhara (mnatsuhara)
approved these changes
Jun 21, 2021
Miya Natsuhara (mnatsuhara)
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay in getting to this, seems like a good and reasonable change! We need to hurry up and have a leap second post-2018 so we can test this more robustly :P
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 22, 2021
Member
|
Thanks for fixing this lurking correctness bug! 🪲 ⌚ 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1899
This PR does not address #1822.
Edited to link to newly-created issue #1899, made while cleaning out the chrono project.