Skip to content

add info to workaround issue#981 - #1906

Closed
Igor Zhukov (fsb4000) wants to merge 1 commit into
microsoft:mainfrom
fsb4000:patch-2
Closed

add info to workaround issue#981#1906
Igor Zhukov (fsb4000) wants to merge 1 commit into
microsoft:mainfrom
fsb4000:patch-2

Conversation

@fsb4000

Copy link
Copy Markdown
Contributor

issue #981

I think that this information will be useful until the python test scripts are rewritten so that they can work with any active codepage.

If you have a better wording for this item then let me know.

@fsb4000
Igor Zhukov (fsb4000) requested a review from a team as a code owner May 4, 2021 13:43
@CaseyCarter Casey Carter (CaseyCarter) added the documentation Related to documentation or comments label May 5, 2021
@fsb4000

Copy link
Copy Markdown
Contributor Author

python 3.9.5 broke the workaround :(

3.9.5
3.9.4

@fsb4000

Copy link
Copy Markdown
Contributor Author

Changing Windows 10 user inteface to English helped with python 3.9.5. Tests passes...
interface

@fsb4000

Copy link
Copy Markdown
Contributor Author

I found an another method.
If you have Visual Studio installed with only English language pack then tests passes without any manipulations with chcp or changing Windows user interface language.
(Previously I had 2 language packs installed: Russian and English)

@cpplearner

S. B. Tam (cpplearner) commented Jun 18, 2021

Copy link
Copy Markdown
Contributor

Can we either fix the compiler warnings or change the script to decode the output with the current console code page (e.g. change out = out.decode() to something like out = out.decode(encoding=f"cp{__import__('ctypes').cdll.kernel32.GetConsoleOutputCP()}"))?

@fsb4000

Copy link
Copy Markdown
Contributor Author

I experimented a little and realized that it was enough to change these settings
Settings and then: All Settings -> Time & Language -> Language -> "Administrative Language Settings" -> "Administrative" -> "Change system locale"
to English.
Windows 10 user inteface remains in the local language.
изображение

So currently 2 working solutions:

  1. Visual Studio installed with only English language pack

or

  1. Change Settings and then: All Settings -> Time & Language -> Language -> "Administrative Language Settings" -> "Administrative" -> "Change system locale" to English.

But I think S. B. Tam (@cpplearner) is right. We should fix it in the python scripts.
So I'm going to close this PR.
If someone will have a problem with the tests, then we can suggest these 2 solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants