<ranges> Invalidate the cached position of a view after move - #1931
Merged
Stephan T. Lavavej (StephanTLavavej) merged 11 commits intoAug 6, 2021
Merged
Stephan T. Lavavej (StephanTLavavej) merged 11 commits into
Stephan T. Lavavej (StephanTLavavej) merged 11 commits into
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
May 26, 2021 10:09
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jun 2, 2021
Casey Carter (CaseyCarter)
suggested changes
Aug 4, 2021
Casey Carter (CaseyCarter)
approved these changes
Aug 4, 2021
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good - I'll go ahead and push superficial changes.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 5, 2021
Member
|
FYI Casey Carter (@CaseyCarter) I pushed trivial changes after you approved, to fix the issues that Adam Bucior (@AdamBucior) and I identified. |
Casey Carter (CaseyCarter)
approved these changes
Aug 5, 2021
Member
|
Thanks for fixing this bug! 🐛 😸 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should invalidate the cached position after a move