Adopt LWG-3555 {transform,elements}_view::iterator::iterator_concept should consider const-qualification of the underlying range - #1989
Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits intoJun 29, 2021
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
June 9, 2021 09:55
36 tasks
{transform,elements}_view::*iterator*::iterator_concept should consider const-qualification of the underlying range
{transform,elements}_view::*iterator*::iterator_concept should consider const-qualification of the underlying range{transform,elements}_view::iterator::iterator_concept should consider const-qualification of the underlying range
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jun 22, 2021
Casey Carter (CaseyCarter)
approved these changes
Jun 24, 2021
Member
|
Thanks for implementing this LWG issue resolution and improving the quality of ranges! 😸 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not add tests yet, as we currently do not test it for elements_view at all and we should think about how / whether it makes sense to test this generically