Adopt LWG-3533 Make base() const & consistent across iterator wrappers that support input_iterators - #1993
Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits intoJul 30, 2021
Conversation
I did split out transform_view::iterator tests Addresses microsoft#1965
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
June 9, 2021 13:21
base() const & consistent across iterator wrappers that support input_iterators
36 tasks
Co-authored-by: S. B. Tam <cpplearner@outlook.com>
Casey Carter (CaseyCarter)
suggested changes
Jun 22, 2021
Co-authored-by: Casey Carter <cacarter@microsoft.com>
Casey Carter (CaseyCarter)
approved these changes
Jul 15, 2021
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good, I'll push the dropped noexcepts.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 27, 2021
Member
|
FYI Casey Carter (@CaseyCarter), I pushed simple changes after you approved. |
Casey Carter (CaseyCarter)
approved these changes
Jul 27, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Jul 27, 2021
Member
|
Thanks for implementing this LWG issue! 😸 ✔️ 🎉 |
Michael Schellenberger Costa (miscco)
deleted the
LWG-3533-iterator-base
branch
August 3, 2021 19:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A I failed to get element_view to accept my clumsy tests.
Does it add value?