Implement P1425 iterator range constructors for stack and queue - #1994
Merged
Stephan T. Lavavej (StephanTLavavej) merged 19 commits intoAug 17, 2021
Merged
Conversation
Addresses microsoft#1965
Addresses microsoft#1965
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
June 9, 2021 16:29
This comment has been minimized.
This comment has been minimized.
Michael Schellenberger Costa (miscco)
force-pushed
the
p1425r4-stack-queue-constructors
branch
from
June 12, 2021 09:27
b3116f8 to
ccdf327
Compare
Contributor
|
Is it intended not to apply LWG-3506 to C++14/17 modes? |
Contributor
Author
|
That is a good point. The maintainers can give direction |
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jun 18, 2021
Comment on lines
+275
to
+276
| template <class _InIt, class _Alloc, enable_if_t<uses_allocator_v<_Container, _Alloc>, int> = 0> | ||
| priority_queue(_InIt _First, _InIt _Last, const _Pr& _Pred, const _Container& _Cont, const _Alloc& _Al) |
There was a problem hiding this comment.
According to LWG-3522, all of these priority_queue constructors taking _InIt should be additionally constrained by _Is_iterator, so I think we need to conjunction_v all 4 of them.
Contributor
Author
There was a problem hiding this comment.
I went with simple && as I believe we do not really need the short circuiting of conjunction and might avoid some type instantiations
Michael Schellenberger Costa (miscco)
force-pushed
the
p1425r4-stack-queue-constructors
branch
from
June 22, 2021 20:01
139a594 to
a9e8c3d
Compare
This comment has been minimized.
This comment has been minimized.
…eduction Guides" This reverts commit 55cea37.
36 tasks
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! I'll validate and push some changes.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 13, 2021
Member
|
I'm mirroring this to an MSVC-internal PR. It's totally fine to push changes for code review feedback, but please notify me in that case. |
Casey Carter (CaseyCarter)
approved these changes
Aug 16, 2021
| using namespace std; | ||
|
|
||
| constexpr int some_data[] = {0, 1, 2, 3, 4, 5}; | ||
| constexpr int additional_data[] = {6, 7, 8, 9, 10, 11}; |
Contributor
There was a problem hiding this comment.
These variable names are truly inspired. (No change requested.)
Member
|
Thanks for implementing this C++23 feature and related LWG issue resolutions! 😻 ✔️ 🚀 |
Michael Schellenberger Costa (miscco)
deleted the
p1425r4-stack-queue-constructors
branch
August 21, 2021 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements P1425.
While we are at it it also implements LWG-3506 and LWG-3522. (There is nothing to do for LWG-3529 - it's already implemented.)
Addresses #1965
Fixes #1973