Implement P0448R4 spanstream - #2029
Merged
Stephan T. Lavavej (StephanTLavavej) merged 35 commits intoSep 11, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
requested a review
from a team
as a code owner
June 30, 2021 13:55
Co-authored-by: Matt Stephanson <68978048+MattStephanson@users.noreply.github.com>
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>
Stephan T. Lavavej (StephanTLavavej)
requested changes
Jul 23, 2021
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Partial review (to be available as a video recording in the near future), I looked at everything except stl/inc/spanstream and P0448R4_spanstream/test.cpp.
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
This comment has been minimized.
This comment has been minimized.
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Video reviewed basic_spanbuf and the recent commits; basic_ispanstream and below, and the new test, remain. (This is a lot of code, thanks for working on it! 😻)
Co-authored-by: Stephan T. Lavavej <stl@microsoft.com>
Also, this test can assume that concepts are available.
This comment has been minimized.
This comment has been minimized.
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Thanks! I'll validate and push changes.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 28, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Stephan T. Lavavej (StephanTLavavej)
requested changes
Aug 29, 2021
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 30, 2021
Co-authored-by: Charlie Barto <chbarto@microsoft.com>
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 8, 2021
Member
|
Michael Schellenberger Costa (@miscco) I pushed changes to use variable templates in the test as Charlie Barto (@barcharcraz) suggested. It's slightly fewer lines of source code, and avoids emitting function calls (which isn't a big deal in test code, but can make stepping through a bit nicer). I also took this opportunity to rename |
Charlie Barto (barcharcraz)
approved these changes
Sep 10, 2021
Member
|
I'm mirroring this to the MSVC-internal repo now. Please notify me if any further changes are pushed. |
Member
|
Thanks for continuing to implement a stream of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements spanstream that was recently voted into C++23
Fixes #1970