Skip to content

<chrono> LWG-3536: leave duration unchanged on failed parse - #2037

Merged
Stephan T. Lavavej (StephanTLavavej) merged 5 commits into
microsoft:mainfrom
yuanhongzhao:gh-1740
Aug 17, 2021
Merged

<chrono> LWG-3536: leave duration unchanged on failed parse#2037
Stephan T. Lavavej (StephanTLavavej) merged 5 commits into
microsoft:mainfrom
yuanhongzhao:gh-1740

Conversation

@yuanhongzhao

@yuanhongzhao yuanhongzhao commented Jul 3, 2021

Copy link
Copy Markdown
Contributor

Fixes #1740.

@yuanhongzhao
yuanhongzhao requested a review from a team as a code owner July 3, 2021 07:06
@ghost

Deleted user (ghost) commented Jul 3, 2021 •
edited by ghost
Loading

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added chrono C++20 chrono LWG Library Working Group issue labels Jul 3, 2021
mnatsuhara
Miya Natsuhara (mnatsuhara) suggested changes Jul 30, 2021
View reviewed changes

@mnatsuhara Miya Natsuhara (mnatsuhara) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this issue! Apologies for the delay in review, the maintainers have been steadily working through the PR backlog. The actual product code changes look great, the only changes I'm requesting are some additional test cases! Once you add those, I'll be satisfied 😸

Comment thread tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated
Comment thread tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated
Comment thread tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated
Closed
36 tasks
mnatsuhara
Miya Natsuhara (mnatsuhara) approved these changes Aug 13, 2021
View reviewed changes

@mnatsuhara Miya Natsuhara (mnatsuhara) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing changes addressing my review comments! These changes look good to me -- moving into "Final Review" mode now 😸

StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) reviewed Aug 13, 2021
View reviewed changes

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this LWG issue resolution! This looks good to me - I'll push changes for minor clarity improvements.

Comment thread tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated
Comment thread tests/std/tests/P0355R7_calendars_and_time_zones_io/test.cpp Outdated
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Aug 13, 2021

Copy link
Copy Markdown
Member

FYI Miya Natsuhara (@mnatsuhara), I pushed minor changes after you approved.

@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Aug 14, 2021

Copy link
Copy Markdown
Member

I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit 3c015bd into microsoft:main Aug 17, 2021
@StephanTLavavej

Stephan T. Lavavej (StephanTLavavej) commented Aug 17, 2021

Copy link
Copy Markdown
Member

Thanks for implementing this LWG issue resolution, and congratulations on your first microsoft/STL commit! 🎉 😻 🚀

This will ship in VS 2022 17.1 Preview 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) StephanTLavavej approved these changes
+2 more reviewers
@MattStephanson Matt Stephanson (MattStephanson) MattStephanson left review comments
@mnatsuhara Miya Natsuhara (mnatsuhara) mnatsuhara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej Stephan T. Lavavej (StephanTLavavej)

Labels

chrono C++20 chrono LWG Library Working Group issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LWG-3536 Should chrono::from_stream assign zero to duration for failure?

4 participants

@yuanhongzhao @StephanTLavavej @mnatsuhara @MattStephanson