Skip to content

Optimize <xstring> memmove function #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 26 commits into from
Jul 20, 2021
Merged

Optimize <xstring> memmove function #2055

Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
6ab4922
Add more c string functions to cstring
AZero13 Jul 10, 2021
73fe567
Remove not standard c function
AZero13 Jul 10, 2021
dad12b0
Remove more c string functions not in the c string library
AZero13 Jul 10, 2021
6c750fe
Have it pass
AZero13 Jul 10, 2021
5a9f39f
Update expected_results.txt
AZero13 Jul 10, 2021
37df6d6
Update expected_results.txt
AZero13 Jul 10, 2021
f9d4973
Remove bad names
AZero13 Jul 10, 2021
c48fdb6
Add strnlen to tests
AZero13 Jul 10, 2021
3b7ad25
Fix formatting
AZero13 Jul 10, 2021
d4df5e4
Fix formatting
AZero13 Jul 10, 2021
adcf708
Format fix
AZero13 Jul 10, 2021
d78bbbb
Use for string
AZero13 Jul 11, 2021
94cf8c9
Optimize xstring some more (#2)
AZero13 Jul 11, 2021
815cb9a
Don’t bother with strnlen if the width is less than 0
AZero13 Jul 11, 2021
08c2194
Fix formatting
AZero13 Jul 11, 2021
bf73433
Fix error
AZero13 Jul 11, 2021
e591573
Fix for loop that SHOULDN’T cause tests to fail but for some reason M…
AZero13 Jul 11, 2021
9d10265
Rearrange variables
AZero13 Jul 12, 2021
946ebec
Update xstring
AZero13 Jul 12, 2021
0f7dbd7
Revert some changes
AZero13 Jul 12, 2021
aa79edb
Update xstring
AZero13 Jul 12, 2021
1ae1fe6
Create xstring
AZero13 Jul 12, 2021
05d516e
Update xstring
AZero13 Jul 12, 2021
7f244e4
Remove strnlen
AZero13 Jul 13, 2021
f60010d
Remove strnlen
AZero13 Jul 13, 2021
07faf1b
Using != universally for unsigned variables is much better
AZero13 Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stl/inc/xstring
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ struct _Char_traits { // properties of a string or stream element
#ifdef __cpp_lib_is_constant_evaluated
if (_STD is_constant_evaluated()) {
// pre: [_First1, _First1 + _Count) and [_First2, _First2 + _Count) do not overlap; see LWG-3085
for (size_t _Idx = 0; _Idx < _Count; ++_Idx) {
for (size_t _Idx = 0; _Idx != _Count; ++_Idx) {
_First1[_Idx] = _First2[_Idx];
}

Expand Down Expand Up @@ -106,12 +106,12 @@ struct _Char_traits { // properties of a string or stream element
}

if (_Loop_forward) {
for (size_t _Idx = 0; _Idx < _Count; ++_Idx) {
for (size_t _Idx = 0; _Idx != _Count; ++_Idx) {
_First1[_Idx] = _First2[_Idx];
}
} else {
for (size_t _Idx = 0; _Idx < _Count; ++_Idx) {
_First1[_Count - 1 - _Idx] = _First2[_Count - 1 - _Idx];
for (size_t _Idx = _Count; _Idx != 0; --_Idx) {
_First1[_Idx - 1] = _First2[_Idx - 1];
}
}

Expand Down