<regex>: add checks for integer overflow - #2169
Merged
Stephan T. Lavavej (StephanTLavavej) merged 18 commits intoAug 27, 2022
Merged
Conversation
Igor Zhukov (fsb4000)
marked this pull request as draft
August 29, 2021 15:47
Co-authored-by: Alex Guteniev <gutenev@gmail.com>
Igor Zhukov (fsb4000)
force-pushed
the
fix2168
branch
from
August 29, 2021 16:40
021e6f1 to
bc2c6b8
Compare
Igor Zhukov (fsb4000)
marked this pull request as ready for review
August 29, 2021 17:09
Alex Guteniev (AlexGuteniev)
approved these changes
Aug 29, 2021
Igor Zhukov (fsb4000)
marked this pull request as draft
August 30, 2021 15:31
Igor Zhukov (fsb4000)
marked this pull request as ready for review
September 4, 2021 02:27
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Going to push test changes, then check product code.
nicole mazzuca (strega-nil-ms)
suggested changes
Aug 10, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Needs some more testing changes
Igor Zhukov (fsb4000)
force-pushed
the
fix2168
branch
from
August 13, 2022 08:23
dc1c1e1 to
9e04327
Compare
nicole mazzuca (strega-nil-ms)
approved these changes
Aug 24, 2022
nicole mazzuca (strega-nil-ms)
left a comment
Contributor
There was a problem hiding this comment.
Thanks so much!
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Aug 26, 2022
Member
|
Thanks, this looks correct and complete to me! FYI nicole mazzuca (@strega-nil-ms) I pushed minor style changes and additional test cases after you approved. |
Member
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
Member
|
Thanks two billion, one hundred forty-seven million, four hundred eighty-three thousand, six hundred forty-eight times for fixing this long-standing incorrect behavior! 🧮 🐞 😹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2168