Skip to content

cleared comment TRANSITION - #2186

Merged
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
AnudeepGunukula:main
Sep 11, 2021
Merged

cleared comment TRANSITION #2186
Stephan T. Lavavej (StephanTLavavej) merged 2 commits into
microsoft:mainfrom
AnudeepGunukula:main

Conversation

@AnudeepGunukula

Copy link
Copy Markdown
Contributor

Closes #2182

this pr will close the above issue .
i had removed all the 11 occurences of // TRANSITION, GH-489 across 4 files (<compare>, <functional>, <system_error>, and <xutility>).

@ghost

Deleted user (ghost) commented Sep 3, 2021

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

Comment thread stl/inc/system_error Outdated
@StephanTLavavej Stephan T. Lavavej (StephanTLavavej) added the documentation Related to documentation or comments label Sep 3, 2021
@StephanTLavavej

Copy link
Copy Markdown
Member

Status update: We merge PRs simultaneously on GitHub and in our MSVC-internal repo. As this is a semi-manual process, we batch up PRs to save effort. Your PR will be part of the next batch, likely at the end of this week. Thanks!

@StephanTLavavej

Copy link
Copy Markdown
Member

Thanks for removing these outdated comments, and congratulations on your first microsoft/STL commit! 😺 🚀 🎉

This will ship in VS 2022 17.1 Preview 1.

@AnudeepGunukula

Copy link
Copy Markdown
Contributor Author

Thankyou Stephan T. Lavavej (@StephanTLavavej)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Related to documentation or comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LWG-3530 BUILTIN-PTR-MEOW should not opt the type out of syntactic checks

5 participants