Implement LWG-3549 - #2198
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoSep 25, 2021
Merged
Conversation
Which (1) makes `enable_view<T>` be `true` for a type `T` which is publicly-and-unambigously derived from a single specialization of `view_interface`, and (2) removes `view_interface`'s inheritance of `view_base`. Fixes microsoft#2178
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 17, 2021
Member
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
Miya Natsuhara (mnatsuhara)
approved these changes
Sep 23, 2021
Member
|
Thanks for implementing this LWG issue resolution! I discovered that if you look at the word "view" often enough, it starts to look brain-meltingly strange. 🤯 🧠 🥵 😹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which (1) makes
enable_view<T>betruefor a typeTwhich is publicly-and-unambigously derived from a single specialization ofview_interface, and (2) removesview_interface's inheritance ofview_base.Fixes #2178