Implement LWG-3520 - #2200
Merged
Stephan T. Lavavej (StephanTLavavej) merged 7 commits intoSep 25, 2021
Merged
Conversation
Michael Schellenberger Costa (miscco)
left a comment
Contributor
There was a problem hiding this comment.
Looks good.
To ensure that we indeed cannot do this, it would be great if you would add a concept ``CanIterSwap` to range_algorithm_support.h like
template <class I>
concept CanIterSwap = requires(I&& i1, I&& i2) {
ranges::iter_swap(std::forward<I>(i1), std::forward<I>(i2));
};and verify that it is not fulfilled
Co-authored-by: Adam Bucior <35536269+AdamBucior@users.noreply.github.com>
Igor Zhukov (fsb4000)
force-pushed
the
fix2180
branch
from
September 12, 2021 14:11
fc2c151 to
d9c637d
Compare
Casey Carter (CaseyCarter)
approved these changes
Sep 13, 2021
Casey Carter (CaseyCarter)
left a comment
Contributor
There was a problem hiding this comment.
Looks great.
Stephan T. Lavavej (StephanTLavavej)
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks! I'll push a comment change.
Stephan T. Lavavej (StephanTLavavej)
approved these changes
Sep 17, 2021
Member
|
I'm mirroring this to an MSVC-internal PR. Please notify me if any further changes are pushed. |
Casey Carter (CaseyCarter)
approved these changes
Sep 24, 2021
Member
|
Thanks for implementing and testing this LWG issue resolution, one step closer to 100% conformance! 💯 😸 ✔️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2180