Skip to content

<random>: Implement LWG-3519 #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Stephan T. Lavavej (StephanTLavavej) merged 8 commits into from
Dec 17, 2021
Merged

<random>: Implement LWG-3519 #2208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8934fd1
Dedicated macro for [[nodiscard]] hidden friends
MattStephanson Sep 15, 2021
9ff7b4a
convert to hidden friends
MattStephanson Sep 15, 2021
89b4676
inline various functions
MattStephanson Sep 16, 2021
36e2650
test failures
MattStephanson Sep 17, 2021
48ad395
Merge branch 'main' into lwg-3519
StephanTLavavej Nov 23, 2021
0492039
Prefer positive preprocessor. Purr!
StephanTLavavej Nov 23, 2021
5c7bbdf
Don't apply `[[nodiscard]] friend` workaround for clang-CUDA
CaseyCarter Dec 16, 2021
8deb179
`and` is super ultra forbidden in this codebase.
StephanTLavavej Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions stl/inc/iterator
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,10 +1477,7 @@ public:
return _Tmp;
}

#ifndef __CUDACC__ // TRANSITION, VSO-568006
_NODISCARD
#endif // TRANSITION, VSO-568006
friend constexpr checked_array_iterator operator+(
_NODISCARD_FRIEND constexpr checked_array_iterator operator+(
const difference_type _Off, const checked_array_iterator<_Ptr>& _Next) noexcept {
return _Next + _Off;
}
Expand Down Expand Up @@ -1656,10 +1653,7 @@ public:
return _Tmp;
}

#ifndef __CUDACC__ // TRANSITION, VSO-568006
_NODISCARD
#endif // TRANSITION, VSO-568006
friend constexpr unchecked_array_iterator operator+(
_NODISCARD_FRIEND constexpr unchecked_array_iterator operator+(
const difference_type _Off, const unchecked_array_iterator& _Next) noexcept {
return _Next + _Off;
}
Expand Down
Loading