Skip to content

P1272R4 Byteswapping for fun&&nuf - #2235

Merged
Stephan T. Lavavej (StephanTLavavej) merged 12 commits into
microsoft:mainfrom
AlexGuteniev:bswap
Oct 20, 2021
Merged

P1272R4 Byteswapping for fun&&nuf#2235
Stephan T. Lavavej (StephanTLavavej) merged 12 commits into
microsoft:mainfrom
AlexGuteniev:bswap

Conversation

@AlexGuteniev

@AlexGuteniev Alex Guteniev (AlexGuteniev) commented Oct 4, 2021

Copy link
Copy Markdown
Contributor

The paper misses __cpp_lib_byteswap value, picked the current date as a speculation

Fixes #2247.

@AlexGuteniev
Alex Guteniev (AlexGuteniev) requested a review from a team as a code owner October 4, 2021 18:14
Comment thread stl/inc/bit Outdated
@CaseyCarter Casey Carter (CaseyCarter) added the cxx23 C++23 feature label Oct 4, 2021
Comment thread stl/inc/bit Outdated
Comment thread tests/std/tests/P1272R4_byteswap/test.cpp Outdated
Comment thread tests/std/tests/P1272R4_byteswap/test.cpp Outdated
Comment thread tests/std/tests/P1272R4_byteswap/test.cpp
Comment thread stl/inc/bit
Comment thread stl/inc/bit Outdated
Comment thread tests/std/tests/P1272R4_byteswap/test.cpp Outdated
@StephanTLavavej

Copy link
Copy Markdown
Member

Alex Guteniev (@AlexGuteniev) Casey Carter (@CaseyCarter) Looks good, thanks. I pushed a couple of tiny changes - please meow if you disagree!

@StephanTLavavej

Copy link
Copy Markdown
Member

I'm mirroring this to an MSVC-internal PR; please notify me if any further changes are pushed.

@StephanTLavavej
Stephan T. Lavavej (StephanTLavavej) merged commit a6718c2 into microsoft:main Oct 20, 2021
@StephanTLavavej

Copy link
Copy Markdown
Member

🚀 😻 🎉 !sknahT

AZero13 (AZero13) pushed a commit to AZero13/STL that referenced this pull request Nov 4, 2021
Co-authored-by: Stephan T. Lavavej <stl@nuwen.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cxx23 C++23 feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P1272R4 byteswap()

4 participants