Consistently use "int = 0" SFINAE - #226
Conversation
|
I've tried to do this before and been stopped by compiler bugs every time. Maybe this time will work :) |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It looks like anywhere there's a forward declaration your changes caused damage. At least |
|
Billy O'Neal (@BillyONeal) , sorry For the noise. I should have seen that I only changed one definition of swap. I think it should be fixed together with the one from chrono. As far as I can tell, this should only ever occur with a defaulted on named template type at the end of the template arguments. So I grepped for |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It appears that this fails to build - do you observe that locally? |
e0ae52a to
fe0d9c3
Compare
|
Stephan T. Lavavej (@StephanTLavavej) I tested a complete rebuild in x64. that works |
|
Grepping for |
|
Addressed the |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Stephan T. Lavavej (StephanTLavavej)
left a comment
There was a problem hiding this comment.
I've ported this to our Microsoft-internal git repo and I'm running builds and tests now. The related PR #244 encountered compiler bugs in two different front-ends, so we'll see what happens.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
b97a7d0 to
2977703
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
FYI, I've gotten our internal tests to pass, but I'm going to have to push additional changes - reverting Casey's addition, and reverting the |
Add TRANSITION comments for microsoft#248 and microsoft#249, blocked by compiler bugs. Add `_Enabled` names. When we don't have `enable_if_t`, this makes the template parameter's purpose clearer. When we do have `enable_if_t` but without `= 0`, this makes it somewhat clearer that we haven't forgotten the default argument (it's simply elsewhere).
2977703 to
ec0608d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks everyone for your contributions! |
|
Thanks for the consistency improvement! |
Description
I had too much time at hand, so this addresses #187
I grepped for all occurences of
class =and fixed those that were followed by anenable_ifChecklist
If you're unsure about a box, leave it unchecked. A maintainer will help you.
community PRs will be delayed until the test and CI systems are online.
_Uglyas perhttps://eel.is/c++draft/lex.name#3.1 or there are no product code changes.
verified by an STL maintainer before CI is online, leave this unchecked for
initial submission).
members, adding virtual functions, changing whether a type is an aggregate
or trivially copyable, etc.).
the C++ Working Draft as a reference (and any other cited standards).
If they were derived from a project that's already listed in NOTICE.txt,
that's fine, but please mention it. If they were derived from any other
project (including Boost and libc++, which are not yet listed in
NOTICE.txt), you must mention it here, so we can determine whether the
license is compatible and what else needs to be done.