Fix/improve intrinsics usage for ARM64EC - #2306
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit intoOct 29, 2021
Merged
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Stephan T. Lavavej (StephanTLavavej) merged 1 commit into
Conversation
…4EC, and enable NEON paths for ARM64EC".
Stephan T. Lavavej (StephanTLavavej)
requested a review
from a team
as a code owner
October 28, 2021 19:38
Contributor
... which Casey approved without a GitHub port 🤦 |
Casey Carter (CaseyCarter)
approved these changes
Oct 28, 2021
Curtis J Bezault (cbezault)
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors Ben Niu's MSVC-PR-361004 "Disable x64 code paths that use tzcnt for ARM64EC, and enable NEON paths for ARM64EC".
The
_HAS_NEON_INTRINSICSchange is a performance improvement - ARM64EC has access to these ARM64 intrinsics.The
tzcntchange is a bugfix (fixing broken builds) - ARM64EC does not have access to this x86/x64 intrinsic.